python / python/cpython

call-matcher breaks if a method is mocked with spec=True

Open
#71,902 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3.7 (EOL) 3.8 (EOL) stdlib type-bug
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

BPO 27715
Nosy @pitrou, @cjw296, @carljm, @voidspace, @eli-b, @mariocj89, @tirkarthi

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2016-08-09.02:43:25.702>
labels = ['3.7', '3.8', 'type-bug', 'library']
title = 'call-matcher breaks if a method is mocked with spec=True'
updated_at = <Date 2018-12-14.18:11:33.421>
user = 'https://github.com/carljm'

bugs.python.org fields:

activity = <Date 2018-12-14.18:11:33.421>
actor = 'xtreak'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2016-08-09.02:43:25.702>
creator = 'carljm'
dependencies = []
files = []
hgrepos = []
issue_num = 27715
keywords = []
message_count = 7.0
messages = ['272209', '272210', '272211', '272212', '286769', '299319', '331846']
nosy_count = 9.0
nosy_names = ['pitrou', 'cjw296', 'carljm', 'michael.foord', 'Eli_B', 'jordan-pittier', 'mariocj89', 'David Hoyes', 'xtreak']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27715'
versions = ['Python 3.7', 'Python 3.8']

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the call-matcher implementation in Python's mocking library and reproduce the failure involving a method mocked with spec=True. Determine the expected matching behavior from the issue's reported bug, then add coverage for the case and verify that the matcher no longer breaks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.