unittest.mock does not wrap dunder methods (__getitem__ etc)

Open
#69,783 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing-qa

Research direction

Start with the unittest.mock behavior described in the issue and review test-mock-wraps-dict.py, the test file linked in the report. Check the existing pull requests #16029 and #19734 before proceeding. Done means dunder methods such as getitem are wrapped as expected and the relevant tests pass.

Written by the indexing model from the issue text.

Description

3.9 (EOL) stdlib type-bug
BPO 25597
Nosy @rbtcollins, @cjw296, @bitdancer, @voidspace, @phmc, @lisroach, @tonybaloney, @mariocj89, @tirkarthi, @akulakov
PRs
  • python/cpython#16029
  • python/cpython#19734
  • Files
  • test-mock-wraps-dict.py
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2015-11-10.17:02:38.914>
    labels = ['type-bug', 'library', '3.9']
    title = 'unittest.mock does not wrap dunder methods (__getitem__ etc)'
    updated_at = <Date 2021-08-28.03:05:05.247>
    user = 'https://bugs.python.org/DarraghBailey'
    

    bugs.python.org fields:

    activity = <Date 2021-08-28.03:05:05.247>
    actor = 'andrei.avk'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2015-11-10.17:02:38.914>
    creator = 'Darragh Bailey'
    dependencies = []
    files = ['41001']
    hgrepos = []
    issue_num = 25597
    keywords = ['patch']
    message_count = 12.0
    messages = ['254453', '254466', '261835', '341615', '351469', '351824', '352124', '352125', '360739', '367559', '367623', '400457']
    nosy_count = 11.0
    nosy_names = ['rbcollins', 'cjw296', 'r.david.murray', 'michael.foord', 'pconnell', 'Darragh Bailey', 'lisroach', 'anthonypjshaw', 'mariocj89', 'xtreak', 'andrei.avk']
    pr_nums = ['16029', '19734']
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue25597'
    versions = ['Python 3.9']
    

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.