shlex.quote doesn't work on bytestrings

Open
#69,753 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
cli

Research direction

Start by reviewing the shlex.quote entry point and the historical shlex_quote_bytes_support.patch referenced in the issue. Then inspect PRs 10871, 22657, and 121741 for the proposed behavior and tests; the issue is done when bytestring quoting is supported consistently with the agreed approach.

Written by the indexing model from the issue text.

Description

stdlib type-feature
BPO 25567
Nosy @bitdancer, @vadmium, @The-Compiler, @willingc, @csabella, @tirkarthi, @aldwinaldwin, @HassanAbouelela, @hrik2001
PRs
  • python/cpython#10871
  • python/cpython#22657
    		•
    Files
  • shlex_quote_bytes_support.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-11-06.12:52:23.798>
labels = ['easy', 'type-feature', 'library', '3.10']
title = "shlex.quote doesn't work on bytestrings"
updated_at = <Date 2021-04-26.21:09:05.326>
user = 'https://bugs.python.org/JonasThiem'

    bugs.python.org fields:

    activity = <Date 2021-04-26.21:09:05.326>
actor = 'hrik2001'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2015-11-06.12:52:23.798>
creator = 'Jonas Thiem'
dependencies = []
files = ['40992']
hgrepos = []
issue_num = 25567
keywords = ['patch', 'easy']
message_count = 9.0
messages = ['254186', '254196', '254429', '256413', '326163', '345569', '370274', '385605', '391986']
nosy_count = 12.0
nosy_names = ['r.david.murray', 'martin.panter', 'The Compiler', 'willingc', 'Nan Wu', 'Jonas Thiem', 'cheryl.sabella', 'xtreak', 'aldwinaldwin', 'HassanAbouelela', 'techfixya', 'hrik2001']
pr_nums = ['10871', '22657']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25567'
versions = ['Python 3.10']

    Linked PRs
    • gh-22657
    • gh-121741
    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.