Clean up and fix OrderedDict

Open
#69,596 35 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by reviewing the OrderedDict extension-module issue and the linked patches: odict_cleanup.patch, odict_cleanup_2.patch, odict_type.patch, odict_add_new_node_leak.patch, odict_revert_setting_on_error.patch, odict_iternext_simpler.patch, odict_resize_sentinel.patch, and odict_copy_iter.patch. The issue is in patch review, so completion would require determining the intended cleanup and fixes and validating them with the relevant test suite.

Written by the indexing model from the issue text.

Description

extension-modules type-bug
BPO 25410
Nosy @rhettinger, @ericsnowcurrently, @serhiy-storchaka, @mr-nfamous, @csabella
Files
  • odict_cleanup.patch
  • odict_cleanup_2.patch
  • odict_type.patch
  • odict_add_new_node_leak.patch
  • odict_revert_setting_on_error.patch
  • odict_iternext_simpler.patch
  • odict_resize_sentinel.patch
  • odict_copy_iter.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-10-15.08:05:08.623>
labels = ['extension-modules', 'type-bug']
title = 'Clean up and fix OrderedDict'
updated_at = <Date 2018-11-04.21:31:17.395>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-11-04.21:31:17.395>
actor = 'rhettinger'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2015-10-15.08:05:08.623>
creator = 'serhiy.storchaka'
dependencies = []
files = ['40785', '40803', '40806', '40817', '40839', '40840', '40841', '41418']
hgrepos = []
issue_num = 25410
keywords = ['patch']
message_count = 35.0
messages = ['253033', '253051', '253110', '253122', '253133', '253134', '253135', '253137', '253139', '253140', '253141', '253142', '253144', '253149', '253217', '253218', '253219', '253221', '253227', '253244', '253341', '253346', '253347', '253349', '254072', '254075', '254152', '254180', '254181', '256922', '256923', '256987', '313971', '329220', '329260']
nosy_count = 6.0
nosy_names = ['rhettinger', 'python-dev', 'eric.snow', 'serhiy.storchaka', 'bup', 'cheryl.sabella']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25410'
versions = ['Python 3.5', 'Python 3.6']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.