urllib bypasses all hosts if proxyoverride includes an empty element

Open
#69,525 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Start with the urllib proxy override handling described in the issue and inspect the two linked patches, cpython_98592.patch and cpython_98593.patch. Reproduce the Windows behavior with an empty proxyoverride element, then run the relevant urllib tests; done means an empty element no longer bypasses all hosts.

Written by the indexing model from the issue text.

Description

OS-windows stdlib type-bug
BPO 25338
Nosy @pfmoore, @tjguk, @bitdancer, @zware, @zooba
Files
  • cpython_98592.patch
  • cpython_98593.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-10-08.05:05:21.294>
labels = ['type-bug', 'OS-windows']
title = 'urllib bypasses all hosts if proxyoverride includes an empty element'
updated_at = <Date 2015-10-14.11:39:02.488>
user = 'https://bugs.python.org/Jung-chihWei'

    bugs.python.org fields:

    activity = <Date 2015-10-14.11:39:02.488>
actor = 'Jung-chih Wei'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2015-10-08.05:05:21.294>
creator = 'Jung-chih Wei'
dependencies = []
files = ['40714', '40715']
hgrepos = []
issue_num = 25338
keywords = ['patch']
message_count = 5.0
messages = ['252510', '252511', '252512', '252536', '252984']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'r.david.murray', 'zach.ware', 'steve.dower', 'Jung-chih Wei']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25338'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.