EmailMessage.add_attachment() creates parts with spurious MIME-Version header.

Open
#69,422 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start with the failing and revised test patches named in the issue, then compare them with fix_mime_version_headers.patch and fix_mime_version_headers-2.patch. Review the email component's attachment behavior and use those tests to verify that add_attachment() no longer adds a spurious MIME-Version header to attachment parts.

Written by the indexing model from the issue text.

Description

stdlib topic-email type-bug
BPO 25235
Nosy @warsaw, @bitdancer, @eriker-fsc
Files
  • test_add_attachment_does_not_add_MIME_Version_in_attachment.patch: failing test case
  • test_add_attachment_does_not_add_MIME_Version_in_attachment.patch: revised failing tests
  • test_MIME_Version.patch: Actually revised patch.
  • fix_mime_version_headers.patch
  • fix_mime_version_headers-2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-09-25.19:47:28.823>
labels = ['type-bug', 'expert-email']
title = 'EmailMessage.add_attachment() creates parts with spurious MIME-Version header.'
updated_at = <Date 2021-01-12.13:38:20.743>
user = 'https://bugs.python.org/groner'

    bugs.python.org fields:

    activity = <Date 2021-01-12.13:38:20.743>
actor = 'eriker'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['email']
creation = <Date 2015-09-25.19:47:28.823>
creator = 'groner'
dependencies = []
files = ['40576', '40577', '40578', '44520', '44644']
hgrepos = []
issue_num = 25235
keywords = ['patch']
message_count = 11.0
messages = ['251600', '251601', '275490', '275552', '275836', '275840', '275963', '276365', '277320', '277337', '384936']
nosy_count = 4.0
nosy_names = ['barry', 'r.david.murray', 'groner', 'eriker']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'commit review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25235'
versions = ['Python 3.5', 'Python 3.6']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.