Windows: subprocess.Popen: race condition for leaking inheritable handles

Open
#69,097 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend, operating-systems

Research direction

Start by reviewing the win32-popen-lock.patch, the referenced pipe.py, and the subprocess.py changes described in the issue. Reproduce or inspect the Windows subprocess race, then verify that the completed change prevents inheritable handles from leaking without regressing subprocess behavior.

Written by the indexing model from the issue text.

Description

OS-windows stdlib topic-subprocess type-bug
BPO 24909
Nosy @gpshead, @pfmoore, @vstinner, @tjguk, @bitdancer, @zware, @zooba, @oconnor663, @ameily
Files
  • win32-popen-lock.patch: Patch to subprocess.py
  • pipe.py
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2015-08-21.16:51:54.533>
labels = ['type-bug', 'library', 'OS-windows']
title = 'Windows: subprocess.Popen: race condition for leaking inheritable handles'
updated_at = <Date 2016-03-04.22:32:34.004>
user = 'https://github.com/ameily'

    bugs.python.org fields:

    activity = <Date 2016-03-04.22:32:34.004>
actor = 'oconnor663'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'Windows']
creation = <Date 2015-08-21.16:51:54.533>
creator = 'meilyadam'
dependencies = []
files = ['40219', '40220']
hgrepos = []
issue_num = 24909
keywords = ['patch']
message_count = 9.0
messages = ['248961', '248962', '248963', '248965', '248970', '248971', '248973', '248976', '250407']
nosy_count = 9.0
nosy_names = ['gregory.p.smith', 'paul.moore', 'vstinner', 'tim.golden', 'r.david.murray', 'zach.ware', 'steve.dower', 'oconnor663', 'meilyadam']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue24909'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5', 'Python 3.6']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.