urllib2 localnet Changed test to lookup IP-address of localhost

Open
#66,942 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python

Research direction

The issue names issue_22753.diff and an urllib2 localnet test; start by reviewing that diff and locating the corresponding test in CPython. Run the focused urllib2 test and confirm it passes without assuming a fixed localhost address.

Written by the indexing model from the issue text.

Description

tests type-bug
BPO 22753
Nosy @ezio-melotti, @bitdancer
Files
  • issue_22753.diff: A patch that does this: localhost_ip = socket.gethostbyname('localhost')
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2014-10-28.14:47:08.763>
    labels = ['type-bug', 'tests']
    title = 'urllib2 localnet Changed test to lookup IP-address of localhost'
    updated_at = <Date 2014-11-03.11:58:35.980>
    user = 'https://bugs.python.org/hakan'
    

    bugs.python.org fields:

    activity = <Date 2014-11-03.11:58:35.980>
    actor = 'hakan'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Tests']
    creation = <Date 2014-10-28.14:47:08.763>
    creator = 'hakan'
    dependencies = []
    files = ['37053']
    hgrepos = []
    issue_num = 22753
    keywords = ['patch']
    message_count = 6.0
    messages = ['230156', '230157', '230158', '230451', '230456', '230534']
    nosy_count = 5.0
    nosy_names = ['ezio.melotti', 'r.david.murray', 'puppet', 'larstiq', 'hakan']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue22753'
    versions = ['Python 3.5']
    

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.