`concurrent.futures.Future.set_running_or_notify_cancel` does not notify cancel

Open
#66,820 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start at concurrent.futures.Future.set_running_or_notify_cancel and compare its cancellation behavior with change-callbacks.patch, change-docs.patch, change-docs-and-waiters.patch, and non-magic-waiters.patch. Determine which documented behavior should apply consistently to callbacks and waiters, then verify the relevant library behavior and documentation.

Written by the indexing model from the issue text.

Description

docs stdlib topic-multiprocessing
BPO 22630
Nosy @brianquinlan, @pitrou
Files
  • change-callbacks.patch: Patch to change callbacks to match docs
  • change-docs.patch: Fixes the documentation to match the current behaviour.
  • change-docs-and-waiters.patch: in addition to fixing the documentation, this also fixes the inconsistency between waiters and callbacks by invoking waiters' add_cancelled method in cancel.
  • non-magic-waiters.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2014-10-14.09:05:54.451>
labels = ['library', 'docs']
title = '`concurrent.futures.Future.set_running_or_notify_cancel` does not notify cancel'
updated_at = <Date 2019-05-07.16:26:55.520>
user = 'https://bugs.python.org/bwhmather'

    bugs.python.org fields:

    activity = <Date 2019-05-07.16:26:55.520>
actor = 'bquinlan'
assignee = 'docs@python'
closed = False
closed_date = None
closer = None
components = ['Documentation', 'Library (Lib)']
creation = <Date 2014-10-14.09:05:54.451>
creator = 'bwhmather'
dependencies = []
files = ['36908', '36909', '36910', '37017']
hgrepos = []
issue_num = 22630
keywords = ['patch']
message_count = 4.0
messages = ['229282', '230017', '303588', '341775']
nosy_count = 4.0
nosy_names = ['bquinlan', 'pitrou', 'docs@python', 'bwhmather']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue22630'
versions = ['Python 3.2', 'Python 3.3', 'Python 3.4', 'Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.