Make bytes() use tp_as_buffer for cmp

Open
#64,538 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by reviewing the linked cmp_buffer.patch and the CPython interpreter-core code involved in bytes comparison. The issue is done when bytes() comparison uses the tp_as_buffer protocol as described, with the relevant interpreter tests passing.

Written by the indexing model from the issue text.

Description

interpreter-core type-feature
BPO 20339
Nosy @nascheme, @ncoghlan, @skrah, @florentx
Files
  • cmp_buffer.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2014-01-22.00:40:29.181>
labels = ['interpreter-core', 'type-feature']
title = 'Make bytes() use tp_as_buffer for cmp'
updated_at = <Date 2014-10-14.15:39:03.136>
user = 'https://github.com/nascheme'

    bugs.python.org fields:

    activity = <Date 2014-10-14.15:39:03.136>
actor = 'skrah'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2014-01-22.00:40:29.181>
creator = 'nascheme'
dependencies = []
files = ['33603']
hgrepos = []
issue_num = 20339
keywords = ['patch']
message_count = 3.0
messages = ['208726', '209352', '229304']
nosy_count = 5.0
nosy_names = ['nascheme', 'ncoghlan', 'skrah', 'flox', 'fin.swimmer']
pr_nums = []
priority = 'low'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20339'
versions = ['Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.