urllib.parse.urlparse() accepts wrong URLs

Open
#64,470 15 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
20/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start at the urllib.parse.urlparse() entry point and review the linked PR gh-155220 alongside the historical urlparse.patch and urlparse_2.patch files. Determine which incorrect URL cases remain unresolved and use the issue's dependency on bpo-20270 as context. Done means the intended parsing behavior is agreed and verified by the relevant tests.

Written by the indexing model from the issue text.

Description

3.10 3.11 3.9 (EOL) stdlib type-bug
BPO 20271
Nosy @gvanrossum, @orsenthil, @vadmium, @serhiy-storchaka, @1st1, @demianbrecht, @tirkarthi
Dependencies
  • bpo-20270: urllib.parse doesn't work with empty port
    		•
    Files
  • urlparse.patch
  • urlparse_2.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2014-01-15.12:32:09.899>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'urllib.parse.urlparse() accepts wrong URLs'
updated_at = <Date 2022-01-17.12:57:05.760>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2022-01-17.12:57:05.760>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2014-01-15.12:32:09.899>
creator = 'serhiy.storchaka'
dependencies = ['20270']
files = ['34300', '38322']
hgrepos = []
issue_num = 20271
keywords = ['patch']
message_count = 14.0
messages = ['208156', '208675', '209852', '212888', '212889', '212890', '236990', '237001', '237157', '237369', '237371', '238982', '338974', '355315']
nosy_count = 7.0
nosy_names = ['gvanrossum', 'orsenthil', 'martin.panter', 'serhiy.storchaka', 'yselivanov', 'demian.brecht', 'xtreak']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20271'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Linked PRs
    • gh-155220
    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.