ftplib: Add client-side SSL session resumption

Open
#63,699 44 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
networking

Research direction

Start by reviewing the attached SSL-client-side-SSL-session-resumption.patch and related implement_ssl_session_reuse patches, then inspect the ftplib behavior they target. Confirm the expected client-side session reuse behavior and use the available patch material to identify the required tests; done means FTP_TLS supports SSL session resumption without regressing existing connections.

Written by the indexing model from the issue text.

Description

stdlib type-feature
BPO 19500
Nosy @pitrou, @giampaolo, @tiran, @alex, @dstufft, @zhangyangyu, @rreilink, @larsschellhas
Files
  • ftplib-FTPS-bug.txt: Python source and command prompt input/output
  • reuse_session.diff: proof-of-concept session reuse
  • implement_ssl_session_reuse.patch: Patch which implements SSL session reuse and fixes corresponding FTP_TLS issue
  • implement_ssl_session_reuse_3.6.patch: Patch which implements SSL session reuse and fixes corresponding FTP_TLS issue targeted at 3.6
  • SSLSession-support.patch
  • sesstime.py
  • SSLSession-support-2.patch
  • SSL-client-side-SSL-session-resumption.patch
  • ftplib_session.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-11-05.04:02:10.597>
labels = ['type-feature', 'library', '3.10']
title = 'ftplib: Add client-side SSL session resumption'
updated_at = <Date 2020-09-23.19:34:39.319>
user = 'https://bugs.python.org/YeWang'

    bugs.python.org fields:

    activity = <Date 2020-09-23.19:34:39.319>
actor = 'larsschellhas'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-11-05.04:02:10.597>
creator = 'Ye.Wang'
dependencies = []
files = ['32505', '40666', '40708', '40716', '44362', '44368', '44376', '44480', '46409']
hgrepos = []
issue_num = 19500
keywords = ['patch']
message_count = 27.0
messages = ['202193', '216674', '216679', '216680', '225078', '252205', '252467', '252468', '252527', '252530', '252543', '252635', '274367', '274391', '274394', '274396', '274417', '274893', '275161', '275703', '275704', '286190', '312885', '370001', '377412', '377413', '377419']
nosy_count = 13.0
nosy_names = ['janssen', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'alex', 'python-dev', 'dstufft', 'Ye.Wang', 'Mark.Ribau', 'xiang.zhang', 'robr', 'Florian Wickert', 'larsschellhas']
pr_nums = []
priority = 'low'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19500'
versions = ['Python 3.10']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.