codeop misclassifies incomplete code with 'nonlocal'

Open
#63,534 26 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start with idle-shell-compile.txt, the reproduction material attached to the issue, and inspect the codeop handling of incomplete code containing nonlocal. Confirm the misclassification and trace the relevant compilation behavior; done means incomplete code is classified correctly without regressing the covered interactive cases.

Written by the indexing model from the issue text.

Description

3.10 3.8 (EOL) 3.9 (EOL) stdlib type-bug
BPO 19335
Nosy @terryjreedy, @ncoghlan, @bitdancer, @markshannon, @Rosuav, @Carreau, @csabella, @lysnikolaou, @pablogsal, @RJ722
Files
  • idle-shell-compile.txt
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-10-21.16:30:00.565>
labels = ['3.8', 'type-bug', 'library', '3.9', '3.10']
title = "codeop misclassifies incomplete code with 'nonlocal'"
updated_at = <Date 2020-07-01.04:13:30.116>
user = 'https://github.com/Rosuav'

    bugs.python.org fields:

    activity = <Date 2020-07-01.04:13:30.116>
actor = 'terry.reedy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-10-21.16:30:00.565>
creator = 'Rosuav'
dependencies = []
files = ['49282']
hgrepos = []
issue_num = 19335
keywords = ['3.3regression']
message_count = 26.0
messages = ['200809', '200839', '200855', '200866', '200885', '200932', '200936', '200943', '200948', '372522', '372523', '372568', '372569', '372571', '372604', '372671', '372681', '372688', '372703', '372707', '372708', '372709', '372710', '372714', '372715', '372729']
nosy_count = 11.0
nosy_names = ['terry.reedy', 'ncoghlan', 'r.david.murray', 'Mark.Shannon', 'Rosuav', 'Esa.Peuha', 'mbussonn', 'cheryl.sabella', 'lys.nikolaou', 'pablogsal', 'RJ722']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19335'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.