urljoin should raise a TypeError if URL is not a string

Open
#63,293 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
30/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Review PR #26687 and the urljoin entry point in Python's urllib library first. Confirm the relevant tests cover non-string URLs and that the completed behavior raises TypeError.

Written by the indexing model from the issue text.

Description

3.11 3.12 3.13 stdlib type-bug
BPO 19094
Nosy @jaraco, @orsenthil, @berkerpeksag, @serhiy-storchaka, @vajrasky, @iritkatriel, @jacobtylerwalls
PRs
  • python/cpython#26687
    		•
    Files
  • urljoin_throws_type_error.patch
  • urljoin_throws_type_error_v2.patch
  • urljoin_throws_type_error_v3.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-09-25.20:55:41.793>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'urljoin should raise a TypeError if URL is not a string'
updated_at = <Date 2021-06-12.01:47:56.398>
user = 'https://github.com/jaraco'

    bugs.python.org fields:

    activity = <Date 2021-06-12.01:47:56.398>
actor = 'jacobtylerwalls'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-09-25.20:55:41.793>
creator = 'jaraco'
dependencies = []
files = ['31876', '31889', '31933']
hgrepos = []
issue_num = 19094
keywords = ['patch']
message_count = 12.0
messages = ['198418', '198435', '198455', '198462', '198493', '198510', '198750', '198784', '198808', '230742', '386875', '395598']
nosy_count = 7.0
nosy_names = ['jaraco', 'orsenthil', 'berker.peksag', 'serhiy.storchaka', 'vajrasky', 'iritkatriel', 'jacobtylerwalls']
pr_nums = ['26687']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19094'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.