urljoin behaves differently with custom and standard schemas

Open
#63,028 22 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Start at the urllib.parse.urljoin entry point and review the linked urljoin-scheme.patch and urljoin-non-hier.patch. Compare how custom and standard schemas are handled, along with the listed RTMP, CoAP, and WebSocket dependencies; done means the behavior is consistent for the affected schemes and the relevant tests pass.

Written by the indexing model from the issue text.

Description

stdlib type-bug
BPO 18828
Nosy @orsenthil, @mher, @berkerpeksag, @vadmium, @demianbrecht
Dependencies
  • bpo-16134: Add support for RTMP schemes to urlparse
  • bpo-23759: urllib.parse: make coap:// known
  • bpo-25895: urllib.parse.urljoin does not handle WebSocket URLs
    		•
    Files
  • urljoin-scheme.patch: scheme not checked
  • urljoin-non-hier.patch: join if not in non_hierarchical
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-08-25.12:52:00.151>
labels = ['type-bug', 'library']
title = 'urljoin behaves differently with custom and standard schemas'
updated_at = <Date 2016-09-13.04:22:49.352>
user = 'https://github.com/mher'

    bugs.python.org fields:

    activity = <Date 2016-09-13.04:22:49.352>
actor = 'martin.panter'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-08-25.12:52:00.151>
creator = 'mher'
dependencies = ['16134', '23759', '25895']
files = ['37480', '38698']
hgrepos = []
issue_num = 18828
keywords = ['patch']
message_count = 16.0
messages = ['196125', '196230', '196515', '196775', '196794', '196795', '232799', '238363', '238497', '238534', '238536', '239125', '239324', '239341', '239363', '276162']
nosy_count = 6.0
nosy_names = ['orsenthil', 'mher', 'berker.peksag', 'martin.panter', 'demian.brecht', 'madison.may']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue18828'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.