json.dump() ignores its 'default' option when serializing dictionary keys

Open
#63,020 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start with the json.dump() and encoder implementation, then review the linked PR gh-119984 and the proposed json-default-dict-keys.diff and json-default-tests.diff files. Check how dictionary keys are serialized in both the default and C implementations. Done means the default option is honored for dictionary keys and regression coverage passes for both paths.

Written by the indexing model from the issue text.

Description

3.10 3.11 3.9 (EOL) stdlib type-bug
BPO 18820
Nosy @rhettinger, @etrepum, @pitrou, @ezio-melotti, @tifv, @berkerpeksag, @serhiy-storchaka, @iritkatriel
Files
  • json-default-dict-keys.diff: applies to default, does not fix C implementation
  • json-default-tests.diff: proposed tests (for default)
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-08-23.10:30:29.980>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = "json.dump() ignores its 'default' option when serializing dictionary keys"
updated_at = <Date 2022-03-13.20:16:36.622>
user = 'https://github.com/tifv'

    bugs.python.org fields:

    activity = <Date 2022-03-13.20:16:36.622>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-08-23.10:30:29.980>
creator = 'july'
dependencies = []
files = ['31437', '31450']
hgrepos = []
issue_num = 18820
keywords = ['patch']
message_count = 8.0
messages = ['195957', '195958', '196022', '196036', '263013', '263019', '263025', '415093']
nosy_count = 11.0
nosy_names = ['rhettinger', 'bob.ippolito', 'pitrou', 'ezio.melotti', 'cvrebert', 'july', 'docs@python', 'berker.peksag', 'serhiy.storchaka', 'Erwin Mayer', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue18820'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Linked PRs
    • gh-119984
    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.