urllib.parse.urlopen shouldn't ignore installed opener when called with any SSL argument

Open
#62,743 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Start by reading urllib.request.py alongside the issue's obsolete urllib.request.py-do-not-overwrite-existing-opener.diff files to understand the opener and SSL interaction. Use ssl_context_tests.py as the available test reference; done means the installed opener is no longer ignored when urlopen receives an SSL argument, with coverage for the reported behavior.

Written by the indexing model from the issue text.

Description

3.7 (EOL) stdlib type-bug
BPO 18543
Nosy @bitdancer, @vadmium, @FirefighterBlu3
Files
  • urlopen-explained.py
  • urllib.request.py-do-not-overwrite-existing-opener.diff: patch is obsolete
  • urllib.request.py-do-not-overwrite-existing-opener.diff: patch is obsolete
  • urllib.request.py-do-not-overwrite-existing-opener.diff: patch is obsolete
  • ssl_context_tests.py
  • urllib.request.py-do-not-overwrite-existing-opener.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2013-07-24.12:26:58.701>
    labels = ['3.7', 'type-bug', 'library']
    title = "urllib.parse.urlopen shouldn't ignore installed opener when called with any SSL argument"
    updated_at = <Date 2018-01-10.09:51:33.130>
    user = 'https://bugs.python.org/moritzs'
    

    bugs.python.org fields:

    activity = <Date 2018-01-10.09:51:33.130>
    actor = 'ber'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2013-07-24.12:26:58.701>
    creator = 'moritzs'
    dependencies = []
    files = ['36074', '39846', '39847', '39848', '39849', '39863']
    hgrepos = []
    issue_num = 18543
    keywords = ['patch']
    message_count = 12.0
    messages = ['193640', '223894', '246096', '246105', '246108', '246120', '246126', '246127', '246268', '257133', '257282', '309761']
    nosy_count = 6.0
    nosy_names = ['ber', 'r.david.murray', 'martin.panter', 'moritzs', 'Alecz', 'David Ford (FirefighterBlu3)']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue18543'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4', 'Python 3.5', 'Python 3.6', 'Python 3.7']
    

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.