tkinter: change API of non-functioning peer_create, does not instantiate Text

Open
#62,145 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
desktop

Research direction

Start by reviewing pythonlevelpeers.py, issue17945.diff, and peerfix.diff to understand the proposed peer_create API and the Text-instantiation problem. Compare the patch approaches with the current Tkinter behavior; done means the API change works and peer_create correctly instantiates Text without breaking related peers.

Written by the indexing model from the issue text.

Description

stdlib topic-tkinter type-feature
BPO 17945
Nosy @terryjreedy, @roseman, @serhiy-storchaka
Files
  • pythonlevelpeers.py: Python script to make peers python objects
  • issue17945.diff: Polo's patch
  • peerfix.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-05-09.14:36:22.353>
labels = ['type-feature', 'expert-tkinter']
title = 'tkinter: change API of non-functioning peer_create, does not instantiate Text'
updated_at = <Date 2015-08-28.20:07:37.285>
user = 'https://bugs.python.org/ghoul'

    bugs.python.org fields:

    activity = <Date 2015-08-28.20:07:37.285>
actor = 'markroseman'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tkinter']
creation = <Date 2013-05-09.14:36:22.353>
creator = 'ghoul'
dependencies = []
files = ['30183', '30205', '30254']
hgrepos = []
issue_num = 17945
keywords = ['patch']
message_count = 12.0
messages = ['188778', '188782', '188784', '188787', '188872', '188908', '188932', '189174', '248956', '248966', '249293', '249295']
nosy_count = 5.0
nosy_names = ['terry.reedy', 'gpolo', 'markroseman', 'serhiy.storchaka', 'ghoul']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17945'
versions = ['Python 3.6']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.