codecs use `assert` for runtime validity checks

Open
#62,040 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
internationalization

Research direction

Start by reviewing the encodings/*_codec.py files and the two issue17840.patch attachments referenced in the issue. Check the existing codec tests for runtime validity cases, then verify that error-mode validation no longer relies on assertions and that the relevant tests pass.

Written by the indexing model from the issue text.

Description

stdlib type-feature
BPO 17840
Nosy @malemburg, @ncoghlan, @vstinner, @ezio-melotti, @berkerpeksag, @vadmium
Files
  • issue17840.patch: Removes error-mode assertions from encodings/*_codec.py
  • issue17840.patch: New patch raising ValueError
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-04-25.07:40:50.545>
labels = ['type-bug', 'library', '3.11']
title = 'base64_codec uses assert for runtime validity checks'
updated_at = <Date 2021-12-12.00:45:46.721>
user = 'https://github.com/ncoghlan'

    bugs.python.org fields:

    activity = <Date 2021-12-12.00:45:46.721>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-04-25.07:40:50.545>
creator = 'ncoghlan'
dependencies = []
files = ['30814', '30902']
hgrepos = []
issue_num = 17840
keywords = ['patch']
message_count = 11.0
messages = ['187762', '192434', '192561', '192638', '192710', '192951', '234303', '234306', '234307', '234613', '348628']
nosy_count = 7.0
nosy_names = ['lemburg', 'ncoghlan', 'vstinner', 'ezio.melotti', 'berker.peksag', 'martin.panter', 'alex.henderson']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue17840'
versions = ['Python 3.11']

    Linked PRs
    • gh-136611
    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.