Add skip_on_windows decorator to test.support

Open
#61,852 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
30/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Start with the test.support module and review the attached skip_on_windows.diff and issue17652_v2.diff patches. Check the existing test-support conventions and verify that the decorator skips its target tests on Windows without affecting other platforms; the issue is complete when this behavior is covered and the relevant tests pass.

Written by the indexing model from the issue text.

Description

tests type-feature
BPO 17652
Nosy @vstinner, @ezio-melotti, @bitdancer, @berkerpeksag, @zware
Files
  • skip_on_windows.diff
  • issue17652_v2.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-04-07.16:47:15.951>
labels = ['type-feature', 'tests']
title = 'Add skip_on_windows decorator to test.support'
updated_at = <Date 2019-04-26.18:33:24.614>
user = 'https://github.com/berkerpeksag'

    bugs.python.org fields:

    activity = <Date 2019-04-26.18:33:24.614>
actor = 'BreamoreBoy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2013-04-07.16:47:15.951>
creator = 'berker.peksag'
dependencies = []
files = ['29718', '30031']
hgrepos = []
issue_num = 17652
keywords = ['patch']
message_count = 6.0
messages = ['186226', '186518', '187905', '222307', '222391', '222509']
nosy_count = 5.0
nosy_names = ['vstinner', 'ezio.melotti', 'r.david.murray', 'berker.peksag', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17652'
versions = ['Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.