datetime.time support for '+' and '-'

Open
#61,469 23 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by reading the attached issue17267 patches, especially issue17267-v3.patch, and inspect the datetime library entry points they target. Review the 22-message thread for the intended arithmetic semantics; the work is done when datetime.time supports the requested '+' and '-' operations with the expected behavior and coverage.

Written by the indexing model from the issue text.

Description

3.8 (EOL) stdlib type-feature
BPO 17267
Nosy @ronaldoussoren, @abalkin, @ericvsmith, @bitdancer, @mmaker, @akheron, @vadmium, @jbatista, @pganssle, @csabella
Files
  • issue17267.patch
  • issue17267.patch: patch for time() + timedelta() (C speedups & pure)
  • issue17267-3.4.diff: time_add and time_subtract
  • issue17267-v2.patch
  • issue17267-v3.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-02-21.12:47:59.278>
labels = ['3.8', 'type-feature', 'library']
title = "datetime.time support for '+' and '-'"
updated_at = <Date 2019-04-14.00:33:03.958>
user = 'https://github.com/ronaldoussoren'

    bugs.python.org fields:

    activity = <Date 2019-04-14.00:33:03.958>
actor = 'martin.panter'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-02-21.12:47:59.278>
creator = 'ronaldoussoren'
dependencies = []
files = ['29200', '29205', '29206', '29225', '29251']
hgrepos = []
issue_num = 17267
keywords = ['patch', 'needs review']
message_count = 22.0
messages = ['182592', '182594', '182595', '182801', '182807', '182814', '182818', '182902', '183090', '183114', '183132', '183137', '183138', '183347', '190697', '190698', '190699', '190700', '212898', '339999', '340046', '340175']
nosy_count = 12.0
nosy_names = ['ronaldoussoren', 'belopolsky', 'eric.smith', 'r.david.murray', 'maker', 'petri.lehtinen', 'francismb', 'martin.panter', 'joar', 'jbatista', 'p-ganssle', 'cheryl.sabella']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17267'
versions = ['Python 3.8']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.