HTTPServer does not correctly handle bad request line

Open
#60,287 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
18/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python

Research direction

Start by reviewing the linked issue16083.tests.patch, issue16083.patch, and issue16083.1.patch to understand the reported bad-request-line behavior and the proposed test coverage. Reproduce the behavior in Python's HTTPServer and confirm that the relevant tests pass with the corrected handling.

Written by the indexing model from the issue text.

Description

stdlib type-bug
BPO 16083
Nosy @terryjreedy, @orsenthil, @tiran, @ezio-melotti, @merwok, @alex, @bitdancer, @mmaker
Files
  • issue16083.tests.patch
  • issue16083.patch
  • issue16083.1.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2012-09-28.10:54:02.189>
    labels = ['type-bug', 'library']
    title = 'HTTPServer does not correctly handle bad request line'
    updated_at = <Date 2013-08-27.18:33:38.668>
    user = 'https://github.com/mmaker'
    

    bugs.python.org fields:

    activity = <Date 2013-08-27.18:33:38.668>
    actor = 'maker'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2012-09-28.10:54:02.189>
    creator = 'maker'
    dependencies = []
    files = ['27336', '27337', '31486']
    hgrepos = []
    issue_num = 16083
    keywords = ['patch']
    message_count = 8.0
    messages = ['171435', '171472', '171483', '171488', '172896', '172901', '172913', '196307']
    nosy_count = 8.0
    nosy_names = ['terry.reedy', 'orsenthil', 'christian.heimes', 'ezio.melotti', 'eric.araujo', 'alex', 'r.david.murray', 'maker']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue16083'
    versions = ['Python 3.4', 'Python 3.5']
    

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.