Unchecked return value of I/O functions

Open
#60,152 19 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Tech stack
c, python
Domain
operating-systems

Research direction

Start by reviewing issue15948__cursesmodule.patch and unchecked_return_values.patch, then inspect the dependency involving Modules/mmapmodule.c. Determine which unchecked I/O return values remain in scope and verify that each is handled consistently; done means the affected checks are covered and the relevant CPython tests pass.

Written by the indexing model from the issue text.

Description

extension-modules type-bug
BPO 15948
Nosy @jcea, @vstinner, @tiran, @ezio-melotti, @socketpair, @felipecruz, @berkerpeksag, @serhiy-storchaka
Dependencies
  • bpo-23860: Windows: Failure to check return value from lseek() in Modules/mmapmodule.c
  • bpo-23878: Missing sanity checks for various C library function calls...
    		•
    Files
  • issue15948__cursesmodule.patch
  • unchecked_return_values.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2012-09-15.15:29:06.752>
labels = ['type-bug']
title = 'Unchecked return value of I/O functions'
updated_at = <Date 2016-03-07.10:54:24.761>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2016-03-07.10:54:24.761>
actor = 'socketpair'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2012-09-15.15:29:06.752>
creator = 'christian.heimes'
dependencies = ['23860', '23878']
files = ['27692', '28253']
hgrepos = []
issue_num = 15948
keywords = ['patch']
message_count = 17.0
messages = ['170521', '170540', '170541', '173662', '173663', '173664', '173668', '174089', '177140', '178577', '179584', '179586', '179597', '179598', '179602', '179603', '261294']
nosy_count = 10.0
nosy_names = ['jcea', 'vstinner', 'christian.heimes', 'ezio.melotti', 'socketpair', 'felipecruz', 'jcon', 'berker.peksag', 'serhiy.storchaka', 'mrshu']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15948'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.