Test pkgutil.walk_packages in test_pkgutil instead of test_runpy

Open
#59,563 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing-qa

Research direction

Compare the pkgutil.walk_packages tests in test_runpy with test_pkgutil, and review the related walk_package support-code refactor described by dependency bpo-15376. Move the tests to test_pkgutil, keeping the shared support code in its common location, then run the affected tests to confirm they pass.

Written by the indexing model from the issue text.

Description

tests type-feature
BPO 15358
Nosy @brettcannon, @ncoghlan, @cjerdonek, @ericsnowcurrently
Dependencies
  • bpo-15343: "pydoc -w <package>" writes out page with empty "Package Contents" section
  • bpo-15376: Refactor the test_runpy walk_package support code into a common location
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2012-07-15.09:54:30.804>
labels = ['type-feature', 'tests']
title = 'Test pkgutil.walk_packages in test_pkgutil instead of test_runpy'
updated_at = <Date 2019-02-24.23:01:58.238>
user = 'https://github.com/ncoghlan'

    bugs.python.org fields:

    activity = <Date 2019-02-24.23:01:58.238>
actor = 'BreamoreBoy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2012-07-15.09:54:30.804>
creator = 'ncoghlan'
dependencies = ['15343', '15376']
files = []
hgrepos = []
issue_num = 15358
keywords = []
message_count = 11.0
messages = ['165516', '165519', '165540', '165616', '165617', '165682', '165686', '221983', '222001', '222055', '222115']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'ncoghlan', 'chris.jerdonek', 'eric.snow']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue15358'
versions = ['Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.