Use sendfile where possible in httplib

Open
#57,768 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Review httplib-sendfile.patch and the two listed dependency issues, bpo-17552 and bpo-23740, before examining the current httplib implementation. Done means using socket.sendfile() where possible in httplib while preserving the request and send behavior covered by those dependencies.

Written by the indexing model from the issue text.

Description

3.12 performance stdlib
BPO 13559
Nosy @orsenthil, @giampaolo, @tiran, @benjaminp, @merwok, @vadmium, @moreati
Dependencies
  • bpo-17552: Add a new socket.sendfile() method
  • bpo-23740: http.client request and send method have some datatype issues
    		•
    Files
  • httplib-sendfile.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2011-12-08.20:47:25.389>
labels = ['library', '3.10', 'performance']
title = 'Use sendfile where possible in httplib'
updated_at = <Date 2021-03-09.10:40:33.692>
user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2021-03-09.10:40:33.692>
actor = 'christian.heimes'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2011-12-08.20:47:25.389>
creator = 'benjamin.peterson'
dependencies = ['17552', '23740']
files = ['35569']
hgrepos = []
issue_num = 13559
keywords = ['patch']
message_count = 13.0
messages = ['149052', '149073', '149075', '149077', '149078', '220262', '250435', '348634', '387699', '387729', '387751', '387754', '388346']
nosy_count = 9.0
nosy_names = ['orsenthil', 'giampaolo.rodola', 'christian.heimes', 'benjamin.peterson', 'eric.araujo', 'rosslagerwall', 'kasun', 'martin.panter', 'Alex.Willmer']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue13559'
versions = ['Python 3.10']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.