urllib2 doesn't escape spaces in http requests

Open
#57,568 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
15/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Start by reviewing the superseding bpo-14826 issue and the listed urllib2-related patches, especially urllib-request-space-encode.diff. Confirm whether the space-escaping behavior is still needed in the current codebase; the existing issue is marked as a duplicate and has no linked pull request or named test.

Written by the indexing model from the issue text.

Description

stdlib type-bug
BPO 13359
Nosy @orsenthil, @ezio-melotti, @karlcow, @sandrotosi, @mmaker, @sorcio, @vadmium
Superseder
  • bpo-14826: urlopen URL with unescaped space
  • Files
  • issue13359.patch: percent encoding of urls to fix the issue reported.
  • issue13359.patch
  • issue13359_py2.patch
  • urllib-request-space-encode.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2011-11-06.20:13:46.480>
    labels = ['type-bug', 'library']
    title = "urllib2 doesn't escape spaces in http requests"
    updated_at = <Date 2017-06-03.05:54:20.991>
    user = 'https://github.com/sorcio'
    

    bugs.python.org fields:

    activity = <Date 2017-06-03.05:54:20.991>
    actor = 'martin.panter'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2011-11-06.20:13:46.480>
    creator = 'davide.rizzo'
    dependencies = []
    files = ['23642', '24215', '24216', '30795']
    hgrepos = []
    issue_num = 13359
    keywords = ['patch']
    message_count = 10.0
    messages = ['147180', '147349', '149441', '151126', '151127', '151129', '151131', '183576', '192400', '295066']
    nosy_count = 11.0
    nosy_names = ['orsenthil', 'kiilerix', 'ezio.melotti', 'karlcow', 'sandro.tosi', 'maker', 'davide.rizzo', 'Ramchandra Apte', 'martin.panter', 'krisys', 'senko']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'test needed'
    status = 'open'
    superseder = '14826'
    type = 'behavior'
    url = 'https://bugs.python.org/issue13359'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']
    

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.