reindent.py inserts spaces in multiline literals

Open
#57,139 22 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start with reindent.py and the attached test_reindent.py, then compare testfile-original.py, testfile-expected.py, and testfile-issue.py to understand the multiline-literal case. Run the existing reindent tests and confirm that fixing the behavior preserves literal contents without inserting spaces.

Written by the indexing model from the issue text.

Description

3.10 3.8 (EOL) 3.9 (EOL) build type-bug
BPO 12930
Nosy @serwy, @merwok, @dimaqq, @serhiy-storchaka
Dependencies
  • bpo-13447: Add tests for some scripts in Tools/scripts
    		•
    Files
  • caioromao-fix-12930-v4.patch
  • bug12930-testfiles.tgz: test
  • testfile-original.py
  • testfile-expected.py
  • testfile-issue.py
  • tab_test.py
  • save_strings.patch: Patch which replaces tab characters in strings with '\t'
  • issue12930.patch
  • test_reindent.py
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2011-09-07.14:29:37.117>
labels = ['type-bug', '3.8', '3.9', '3.10']
title = 'reindent.py inserts spaces in multiline literals'
updated_at = <Date 2020-10-26.00:05:12.927>
user = 'https://github.com/dimaqq'

    bugs.python.org fields:

    activity = <Date 2020-10-26.00:05:12.927>
actor = 'Dima.Tisnek'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Demos and Tools']
creation = <Date 2011-09-07.14:29:37.117>
creator = 'Dima.Tisnek'
dependencies = ['13447']
files = ['23194', '23195', '23500', '23501', '23502', '24074', '24120', '27366', '27367']
hgrepos = []
issue_num = 12930
keywords = ['patch']
message_count = 22.0
messages = ['143679', '143715', '143718', '143999', '144291', '144313', '144314', '144321', '146112', '146169', '146209', '146212', '146213', '148063', '150064', '150425', '150426', '171678', '171679', '171682', '171685', '379621']
nosy_count = 6.0
nosy_names = ['roger.serwy', 'eric.araujo', 'Dima.Tisnek', 'Caio.Romao', 'Jonathan.Rogers', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue12930'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.