"universal newlines" subprocess support broken with select- and poll-based communicate()

Open
#56,832 17 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
20/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python

Research direction

Start by reviewing issue12623_failing_test.diff and the select- and poll-based communicate() behavior described in the issue. Check superseding issue bpo-16903 before investigating further, since this issue has no linked pull request and its historical patch may be out of date. Done would require a current reproducer and passing subprocess tests for universal newlines.

Written by the indexing model from the issue text.

Description

stdlib tests topic-subprocess type-bug
BPO 12623
Nosy @birkenfeld, @gpshead, @pitrou, @bitdancer, @asvetlov, @cjerdonek, @vadmium
Superseder
  • bpo-16903: subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2
  • Files
  • issue12623_failing_test.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2011-07-23.20:11:32.674>
    labels = ['tests', 'type-bug', 'library']
    title = '"universal newlines" subprocess support broken with select- and poll-based communicate()'
    updated_at = <Date 2016-06-12.20:34:36.463>
    user = 'https://github.com/pitrou'
    

    bugs.python.org fields:

    activity = <Date 2016-06-12.20:34:36.463>
    actor = 'BreamoreBoy'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)', 'Tests']
    creation = <Date 2011-07-23.20:11:32.674>
    creator = 'pitrou'
    dependencies = []
    files = ['26837']
    hgrepos = []
    issue_num = 12623
    keywords = ['patch']
    message_count = 17.0
    messages = ['141014', '168317', '168320', '168322', '168325', '168328', '168329', '168330', '168331', '168333', '168335', '168336', '168340', '168557', '169046', '220743', '268346']
    nosy_count = 7.0
    nosy_names = ['georg.brandl', 'gregory.p.smith', 'pitrou', 'r.david.murray', 'asvetlov', 'chris.jerdonek', 'martin.panter']
    pr_nums = []
    priority = 'normal'
    resolution = 'out of date'
    stage = 'patch review'
    status = 'open'
    superseder = '16903'
    type = 'behavior'
    url = 'https://bugs.python.org/issue12623'
    versions = ['Python 3.4', 'Python 3.5']
    

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.