pulldom doesn't provide END_DOCUMENT or COMMENT nodes.

Open
#53,617 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by reviewing the historical test_pulldom.py and pulldom_enddoc_event_fix.patch, then inspect PR 10328 and the current pulldom implementation. Done means pulldom exposes END_DOCUMENT and COMMENT nodes with tests covering both behaviors.

Written by the indexing model from the issue text.

Description

topic-XML type-bug
BPO 9371
Nosy @scoder, @merwok
PRs
  • python/cpython#10328
    		•
    Files
  • test_pulldom.py: A TestCase to demonstrate this issue.
  • pulldom_enddoc_event_fix.patch: bugfix for ENDDOCUMENT event
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2010-07-24.13:01:50.678>
labels = ['expert-XML', 'type-bug']
title = "pulldom doesn't provide END_DOCUMENT or COMMENT nodes."
updated_at = <Date 2019-05-30.20:00:25.245>
user = 'https://bugs.python.org/marksmith'

    bugs.python.org fields:

    activity = <Date 2019-05-30.20:00:25.245>
actor = 'cheryl.sabella'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['XML']
creation = <Date 2010-07-24.13:01:50.678>
creator = 'mark.smith'
dependencies = []
files = ['18183', '24787']
hgrepos = []
issue_num = 9371
keywords = ['patch']
message_count = 3.0
messages = ['111474', '111486', '155409']
nosy_count = 4.0
nosy_names = ['scoder', 'eric.araujo', 'mark.smith', 'flomm']
pr_nums = ['10328']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue9371'
versions = ['Python 3.2']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.