makesetup interprets macros -DA=B as a Make variable definition

Open
#52,186 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
build-system

Research direction

Start at the makesetup entry point and inspect the existing pydiff patch referenced in the issue; compare how a -DA=B macro is handled with Make variable syntax. Reproduce the compile error and verify that the corrected interpretation allows the build to succeed.

Written by the indexing model from the issue text.

Description

3.10 3.11 3.9 (EOL) build
BPO 7938
Nosy @amauryfa, @ericvsmith
PRs
  • python/cpython#4338
  • Files
  • pydiff: patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2010-02-16.00:44:31.245>
    labels = ['build', '3.9', '3.10', '3.11']
    title = 'makesetup interprets macros -DA=B as a Make variable definition'
    updated_at = <Date 2021-10-20.12:52:11.092>
    user = 'https://bugs.python.org/wdebruij'
    

    bugs.python.org fields:

    activity = <Date 2021-10-20.12:52:11.092>
    actor = 'christian.heimes'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Build']
    creation = <Date 2010-02-16.00:44:31.245>
    creator = 'wdebruij'
    dependencies = []
    files = ['16227']
    hgrepos = []
    issue_num = 7938
    keywords = ['patch', 'needs review']
    message_count = 4.0
    messages = ['99378', '112904', '117564', '117569']
    nosy_count = 3.0
    nosy_names = ['amaury.forgeotdarc', 'eric.smith', 'wdebruij']
    pr_nums = ['4338']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue7938'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.