Popen should raise ValueError if pass a string when shell=False or a list when shell=True

Open
#52,087 32 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
operating-systems

Research direction

Read the linked test_subprocess.py test case first, then locate the Popen behavior it exercises. Done means coverage verifies ValueError for a string with shell=False and for a list with shell=True, while preserving the existing subprocess tests.

Written by the indexing model from the issue text.

Description

pending stdlib type-feature
BPO 7839
Nosy @csernazs, @ncoghlan, @vstinner, @larryhastings, @ericvsmith, @giampaolo, @merwok, @bitdancer, @briancurtin, @asvetlov
Files
  • test_subprocess.py: Test case for this bug, works in Python 2 and Python 3.
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2010-02-02.19:08:03.339>
labels = ['type-feature', 'library']
title = 'Popen should raise ValueError if pass a string when shell=False or a list when shell=True'
updated_at = <Date 2013-11-06.19:37:27.696>
user = 'https://github.com/bitdancer'

    bugs.python.org fields:

    activity = <Date 2013-11-06.19:37:27.696>
actor = 'akuchling'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2010-02-02.19:08:03.339>
creator = 'r.david.murray'
dependencies = []
files = ['17587']
hgrepos = []
issue_num = 7839
keywords = []
message_count = 31.0
messages = ['98754', '100202', '100205', '100206', '100207', '100209', '107310', '107311', '107313', '107316', '107322', '107353', '107365', '107369', '107770', '111337', '157217', '157227', '157228', '157230', '157252', '157259', '157269', '157294', '157322', '157323', '157332', '157608', '157613', '157800', '160587']
nosy_count = 15.0
nosy_names = ['holdenweb', 'csernazs', 'ncoghlan', 'vstinner', 'dstanek', 'larry', 'eric.smith', 'giampaolo.rodola', 'eric.araujo', 'Arfrever', 'r.david.murray', 'brian.curtin', 'cvrebert', 'asvetlov', 'Alexander.Belopolsky']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue7839'
versions = ['Python 3.3']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.