unicode_escape codec does not escape quotes

Open
#51,864 27 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Review unicode_escape_tests.patch and unicode_escape_1_minimal.patch first; the issue lists these as unit tests and the proposed quote and backslash escaping fix. Compare them with the current Unicode codec tests and implementation, then verify that the relevant tests pass and quote escaping is covered.

Written by the indexing model from the issue text.

Description

stdlib topic-unicode type-bug
BPO 7615
Nosy @malemburg, @amauryfa, @ezio-melotti, @bitdancer, @florentx, @serhiy-storchaka, @iritkatriel
Files
  • unicode_escape_tests.patch: unit tests
  • unicode_escape_1_minimal.patch: fix escaping of quotes and backslashes for unicode_escape and raw_unicode_escape
  • unicode_escape_2_utf-16_invalid_read.patch: fix UTF-16 invalid read bug
  • unicode_escape_3_check_size_nonnegative.patch: make sure size is nonnegative
  • unicode_escape_4_eliminate_duplicate_code.patch: eliminate duplicate code
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2010-01-01.03:28:23.547>
labels = ['3.10', 'type-bug', '3.9', 'expert-unicode', '3.11']
title = 'unicode_escape codec does not escape quotes'
updated_at = <Date 2021-08-09.20:06:19.174>
user = 'https://bugs.python.org/rhansen'

    bugs.python.org fields:

    activity = <Date 2021-08-09.20:06:19.174>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Unicode']
creation = <Date 2010-01-01.03:28:23.547>
creator = 'rhansen'
dependencies = []
files = ['15809', '15810', '15811', '15812', '15813']
hgrepos = []
issue_num = 7615
keywords = ['patch']
message_count = 27.0
messages = ['97112', '97130', '97183', '97237', '97269', '97279', '97345', '97346', '97352', '97363', '97364', '97365', '97375', '97385', '97485', '97486', '97487', '97488', '97490', '98265', '98275', '98288', '98327', '111826', '111836', '399287', '399288']
nosy_count = 8.0
nosy_names = ['lemburg', 'amaury.forgeotdarc', 'ezio.melotti', 'r.david.murray', 'flox', 'rhansen', 'serhiy.storchaka', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue7615'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.