shlex behaves unexpected if newlines are not whitespace

Open
#51,338 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
cli

Research direction

Review lexertest.py and the two referenced lexer-newline patch files, including the second patch's test cases. Compare the proposed behavior with the current shlex implementation and run the relevant lexer tests; done means the newline-token behavior is covered by tests and the linked PR's change is resolved.

Written by the indexing model from the issue text.

Description

3.13 3.14 3.15 stdlib type-bug
BPO 7089
Nosy @iritkatriel
Files
  • lexertest.py
  • lexer-newline-tokens.patch
  • lexer-newline-tokens-patch-2.0.patch: improved patch, includes test cases
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2009-10-09.08:11:52.254>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'shlex behaves unexpected if newlines are not whitespace'
updated_at = <Date 2021-06-14.20:18:08.262>
user = 'https://bugs.python.org/jjdmol2'

    bugs.python.org fields:

    activity = <Date 2021-06-14.20:18:08.262>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2009-10-09.08:11:52.254>
creator = 'jjdmol2'
dependencies = []
files = ['15087', '15088', '15708']
hgrepos = []
issue_num = 7089
keywords = ['patch']
message_count = 6.0
messages = ['93776', '93778', '93820', '97080', '141486', '395847']
nosy_count = 6.0
nosy_names = ['ggenellina', 'ferringb', 'jjdmol2', 'kanru', 'elliotta', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue7089'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Linked PRs
    • gh-141604
    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.