rlcompleter adds builtins when custom dict is used

Open
#49,506 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
cli

Research direction

Start by reviewing rlcompleter.patch and the later issue5256.patch and issue5256.1.patch, then compare their included unit tests with the rlcompleter_docs.patch. Confirm the intended behavior for a custom dictionary and that the tests cover preventing unintended builtins; the issue is done when the behavior and documentation are consistent.

Written by the indexing model from the issue text.

Description

stdlib type-feature
BPO 5256
Nosy @mdickinson, @pitrou, @vstinner, @ezio-melotti, @merwok, @bitdancer, @mmaker
Files
  • rlcompleter.patch: issue5256 fix + unittests
  • rlcompleter_docs.patch: issue5256 doc
  • issue5256.patch
  • issue5256.1.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2009-02-14.00:04:18.547>
labels = ['type-feature', 'library']
title = 'rlcompleter adds builtins when custom dict is used'
updated_at = <Date 2019-07-29.12:02:35.095>
user = 'https://bugs.python.org/armandas'

    bugs.python.org fields:

    activity = <Date 2019-07-29.12:02:35.095>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2009-02-14.00:04:18.547>
creator = 'armandas'
dependencies = []
files = ['18421', '18427', '27569', '27586']
hgrepos = []
issue_num = 5256
keywords = ['patch', 'needs review']
message_count = 9.0
messages = ['81979', '113154', '113169', '113180', '172914', '172921', '172955', '172999', '348652']
nosy_count = 8.0
nosy_names = ['mark.dickinson', 'pitrou', 'vstinner', 'ezio.melotti', 'eric.araujo', 'r.david.murray', 'armandas', 'maker']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue5256'
versions = ['Python 3.4']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.