smtplib doesn't clear helo/ehlo flags on quit

Open
#48,392 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Start by inspecting the smtplib implementation and the historical helo.patch and flag_reset_4142.patch linked in the issue. Compare their proposed behavior with the current quit handling; done means the HELO/EHLO state is cleared after quit and the behavior is covered by an appropriate regression test.

Written by the indexing model from the issue text.

Description

stdlib topic-email type-bug
BPO 4142
Nosy @loewis, @jcea, @giampaolo, @bitdancer, @sandrotosi
Files
  • helo.patch: Patch against /trunk, can probably be applied for 2.4.x, 2.5.x and 2.6.x also
  • flag_reset_4142.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2008-10-17.20:02:42.197>
labels = ['type-bug', 'library']
title = "smtplib doesn't clear helo/ehlo flags on quit"
updated_at = <Date 2014-03-16.09:35:13.017>
user = 'https://bugs.python.org/dwig'

    bugs.python.org fields:

    activity = <Date 2014-03-16.09:35:13.017>
actor = 'berker.peksag'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2008-10-17.20:02:42.197>
creator = 'dwig'
dependencies = []
files = ['13100', '34316']
hgrepos = []
issue_num = 4142
keywords = ['patch']
message_count = 10.0
messages = ['74935', '82158', '82165', '82287', '82290', '101631', '128157', '128181', '212985', '213050']
nosy_count = 8.0
nosy_names = ['loewis', 'jcea', 'giampaolo.rodola', 'dwig', 'r.david.murray', 'sandro.tosi', 'alfmel', 'varun']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue4142'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.