doctest.py should include method descriptors when looking inside a class __dict__

Open
#48,287 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Start with doctest.py and doctest_test.py, along with the linked historical patches, to understand how DocTestFinder inspects a class dict. Confirm the existing test coverage and update it so method descriptors are included when searching inside classes; the doctest tests should pass with the new behavior.

Written by the indexing model from the issue text.

Description

stdlib type-feature
BPO 4037
Nosy @birkenfeld, @terryjreedy, @ncoghlan, @stevendaprano, @bitdancer, @briancurtin
Files
  • patch: patch to add support for method descriptors to doctest.DocTestFinder
  • doctest_test.py
  • doctest_patch: patch to add support for method descriptors to doctest.DocTestFinder, including updated test for test.test_doctest2
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2008-10-04.00:13:25.010>
labels = ['type-feature', 'library']
title = 'doctest.py should include method descriptors when looking inside a class __dict__'
updated_at = <Date 2014-02-03.15:42:56.586>
user = 'https://bugs.python.org/daaku'

    bugs.python.org fields:

    activity = <Date 2014-02-03.15:42:56.586>
actor = 'BreamoreBoy'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2008-10-04.00:13:25.010>
creator = 'daaku'
dependencies = []
files = ['16158', '16185', '16599']
hgrepos = []
issue_num = 4037
keywords = ['patch', 'needs review']
message_count = 9.0
messages = ['74285', '98974', '98983', '99115', '99145', '101372', '104300', '110690', '205905']
nosy_count = 8.0
nosy_names = ['georg.brandl', 'terry.reedy', 'ncoghlan', 'daaku', 'steven.daprano', 'r.david.murray', 'brian.curtin', 'filip.zyzniewski']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue4037'
versions = ['Python 3.2']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.