difflib.unified_diff(...) produces invalid patches

Open
#46,395 25 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
18/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start with the difflib.unified_diff entry point and review the historical patches listed in the issue, especially issue_2142_2.diff and issue_2142.diff. Compare their intended behavior with the current implementation and determine the expected handling of generated patches; done means unified_diff no longer produces invalid patches and the behavior is covered by regression tests.

Written by the indexing model from the issue text.

Description

stdlib type-feature
BPO 2142
Nosy @tim-one, @birkenfeld, @benjaminp, @jwilk, @merwok, @TBBle, @srinivasreddy, @puxlit
Files
  • python_difflib_unified_diff.patch: patch against the Python 2.6 svn trunk to fix this
  • python_difflib_no_eol.patch: patch (against trunk, currently 2.7) to fix and with test cases
  • issue_2142_trunk.diff: patch against the trunk.
  • issue_2142_py3k.diff: patch against py3k
  • issue_2142_py3k_updated.diff: updated patch against py3k
  • issue_2142.diff
  • issue_2142_2.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2008-02-18.20:16:55.615>
labels = ['type-feature', 'library']
title = 'difflib.unified_diff(...) produces invalid patches'
updated_at = <Date 2021-02-18.19:42:20.958>
user = 'https://bugs.python.org/trentm'

    bugs.python.org fields:

    activity = <Date 2021-02-18.19:42:20.958>
actor = 'djc'
assignee = 'trentm'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2008-02-18.20:16:55.615>
creator = 'trentm'
dependencies = []
files = ['9460', '14082', '17332', '17333', '18081', '21067', '21207']
hgrepos = []
issue_num = 2142
keywords = ['patch']
message_count = 23.0
messages = ['62543', '62544', '62545', '88375', '105636', '105638', '105639', '105647', '105692', '105693', '105762', '110778', '110864', '110866', '118125', '123163', '130491', '130677', '130683', '130801', '130959', '236541', '384192']
nosy_count = 13.0
nosy_names = ['tim.peters', 'georg.brandl', 'techtonik', 'benjamin.peterson', 'jwilk', 'trentm', 'eric.araujo', 'TBBle', 'meatballhat', 'ysj.ray', 'abacabadabacaba', 'thatiparthy', 'puxlit']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue2142'
versions = ['Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.