Add match parameter to filecmp.dircmp to ignore using patterns

Open
#46,079 19 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start with the filecmp.dircmp entry point and review the historical filecmp.py.patch and wildcard.patch files listed in the issue. Compare the revised patches to understand the intended matching behavior and parameter shape. Done means dircmp can ignore entries using the requested patterns without changing existing behavior.

Written by the indexing model from the issue text.

Description

stdlib type-feature
BPO 1738
Nosy @gvanrossum, @abalkin, @mamrhein
Files
  • filecmp.py.patch
  • wildcard.patch: patch implementing an enhanced version of this feature
  • add_match_func.patch: revised patch
  • add_match_func.patch: 2nd revised patch
  • issue1738py3k.diff
  • issue1738.diff
  • issue1738_r2.diff
  • issue1738_r3.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2008-01-04.21:30:31.549>
labels = ['type-feature', 'library']
title = 'Add match parameter to filecmp.dircmp to ignore using patterns'
updated_at = <Date 2014-04-13.19:00:44.462>
user = 'https://bugs.python.org/flxkid'

    bugs.python.org fields:

    activity = <Date 2014-04-13.19:00:44.462>
actor = 'nikratio'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2008-01-04.21:30:31.549>
creator = 'flxkid'
dependencies = []
files = ['9068', '10005', '10008', '10078', '18930', '34444', '34478', '34801']
hgrepos = []
issue_num = 1738
keywords = ['patch']
message_count = 19.0
messages = ['59262', '59265', '59276', '59277', '62893', '64138', '65348', '65351', '65359', '65360', '65363', '65479', '65629', '65701', '107430', '116857', '213748', '213941', '216030']
nosy_count = 7.0
nosy_names = ['gvanrossum', 'jafo', 'belopolsky', 'mamrhein', 'flxkid', 'vdupras', 'nikratio']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue1738'
versions = ['Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.