ZipFile.write fails with bad modification time

Open
#45,243 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by reviewing debug_session.txt, which shows the negative modification time involved in ZipFile.write, and compare it with ignore_negative_modification_time.txt, described as a likely incorrect fix. Reproduce the failure against the current Python library and determine the regression coverage needed before deciding what completion should require.

Written by the indexing model from the issue text.

Description

3.10 3.11 3.9 (EOL) stdlib type-bug
BPO 1760357
Nosy @warsaw, @bitdancer, @briancurtin, @serhiy-storchaka, @tirkarthi
Files
  • debug_session.txt: Debug session showing negative mtime
  • ignore_negative_modification_time.txt: Most likely incorrect fix to avoid this problem
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2007-07-25.14:54:52.000>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'ZipFile.write fails with bad modification time'
updated_at = <Date 2021-10-20.12:53:55.412>
user = 'https://bugs.python.org/gradha'

    bugs.python.org fields:

    activity = <Date 2021-10-20.12:53:55.412>
actor = 'christian.heimes'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2007-07-25.14:54:52.000>
creator = 'gradha'
dependencies = []
files = ['8133', '8134']
hgrepos = []
issue_num = 1760357
keywords = ['patch']
message_count = 6.0
messages = ['52944', '52945', '55307', '58978', '159533', '348574']
nosy_count = 8.0
nosy_names = ['barry', 'gradha', 'alanmcintyre', 'r.david.murray', 'brian.curtin', 'serhiy.storchaka', 'xtreak', 'Linsey Alvarez']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1760357'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.