patch smtplib:when SMTPDataError, rset crashes with sslerror

Open
#43,311 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Read smtplib_nosideeffecterror.patch and issue1481032.patch first, then inspect the smtplib SMTPDataError/rset path. Reproduce the failure where rset raises an SSLError, and use the referenced patch and linked PR context to identify the needed regression coverage; done means that recovery path no longer crashes.

Written by the indexing model from the issue text.

Description

stdlib topic-email type-bug
BPO 1481032
Nosy @warsaw, @terryjreedy, @tiran, @bitdancer, @zvyn
Files
  • smtplib_nosideeffecterror.patch
  • issue1481032.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2006-05-03.11:59:13.000>
labels = ['3.7', 'type-bug', 'library']
title = 'patch smtplib:when SMTPDataError, rset crashes with sslerror'
updated_at = <Date 2016-09-08.15:03:02.164>
user = 'https://bugs.python.org/kxroberto'

    bugs.python.org fields:

    activity = <Date 2016-09-08.15:03:02.164>
actor = 'christian.heimes'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2006-05-03.11:59:13.000>
creator = 'kxroberto'
dependencies = []
files = ['18613', '36057']
hgrepos = []
issue_num = 1481032
keywords = ['patch']
message_count = 10.0
messages = ['50175', '50176', '50177', '114657', '114734', '147683', '223800', '226087', '226101', '275036']
nosy_count = 8.0
nosy_names = ['barry', 'terry.reedy', 'kxroberto', 'christian.heimes', 'hwundram', 'r.david.murray', 'jesstess', 'zvyn']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'pending'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1481032'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

    Linked PRs
    • gh-154866
    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.