http.cookies, Cookie.py: Improper handling of duplicate cookies

Open
#42,664 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by reviewing linked PR gh-116253 and the historical issue1375011-2.7.patch and issue1375011-3.2.patch files. Compare their changes with http/cookies.py and Cookie.py, including the referenced tests and documentation; the work is complete when duplicate-cookie handling is covered and the corresponding tests pass.

Written by the indexing model from the issue text.

Description

3.11 3.12 3.13 easy stdlib type-bug
BPO 1375011
Nosy @Cito, @devdanzin, @karlcow
Files
  • Cookie.py.patch: Patch for revision 41632 of Cookie.py
  • issue1375011-2.7.patch: Patch, test & docs for Cookie.py on 2.7
  • issue1375011-3.2.patch: Patch, test & docs for http/cookies.py on 3.2
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2005-12-07.03:50:53.000>
    labels = ['easy', 'type-bug', '3.8', '3.9', '3.10', 'library']
    title = 'http.cookies, Cookie.py: Improper handling of duplicate cookies'
    updated_at = <Date 2021-01-21.15:12:28.480>
    user = 'https://bugs.python.org/valankar'
    

    bugs.python.org fields:

    activity = <Date 2021-01-21.15:12:28.480>
    actor = 'cito'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2005-12-07.03:50:53.000>
    creator = 'valankar'
    dependencies = []
    files = ['6910', '29178', '29179']
    hgrepos = []
    issue_num = 1375011
    keywords = ['patch', 'easy']
    message_count = 8.0
    messages = ['49178', '49179', '86297', '114634', '182758', '182759', '353845', '385430']
    nosy_count = 7.0
    nosy_names = ['jjlee', 'cito', 'sonderblade', 'valankar', 'ajaksu2', 'karlcow', 'mmelin']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'test needed'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue1375011'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    

    Linked PRs
    • gh-116253
    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.