filecmp.cmp's "shallow" option

Open
#42,172 14 comments 0 reactions 1 assignee View on GitHub

@freddrake is already working on this.

Since Jul 8, 2005.

Assessment

This issue has not been assessed yet.

Description

stdlib type-bug
BPO 1234674
Nosy @freddrake, @birkenfeld, @rhettinger, @sandrotosi, @cjerdonek, @BlckKnght
Files
  • filecmp_real_shallow.diff
  • filecmp_extra_shallow_file_check.diff: Patch of test_filecmp.py which ensures the content of files with same os.stat() signatures are not compared when the shallow option is True
  • filecmp_test_patch.diff: patch to add tests (and to fix tests broken by behavior patch)
  • filecmp_behavior_and_doc_fix.diff: Fix for filecmp.cmp behavior and its documentation
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/freddrake'
closed_at = None
created_at = <Date 2005-07-08.09:01:20.000>
labels = ['type-bug', 'library']
title = 'filecmp.cmp\'s "shallow" option'
updated_at = <Date 2014-08-14.05:09:22.988>
user = 'https://bugs.python.org/goatsofmendez'

    bugs.python.org fields:

    activity = <Date 2014-08-14.05:09:22.988>
actor = 'berker.peksag'
assignee = 'fdrake'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2005-07-08.09:01:20.000>
creator = 'goatsofmendez'
dependencies = []
files = ['35159', '36123', '36238', '36239']
hgrepos = []
issue_num = 1234674
keywords = ['patch']
message_count = 12.0
messages = ['25751', '25752', '25753', '25754', '25755', '25756', '146682', '216937', '217965', '224101', '224128', '224668']
nosy_count = 9.0
nosy_names = ['fdrake', 'georg.brandl', 'rhettinger', 'pvrijlandt', 'goatsofmendez', 'sandro.tosi', 'chris.jerdonek', 'Steven.Barker', 'Andrew.Kubera']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1234674'
versions = ['Python 3.5']

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.