Inconsistent newline handling in email module

Open
#40,414 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start with the email component and review the attached Charset.diff, crlf-body-encode.patch, base_encode_tests.patch, and crlf_base64_body_encode.patch. Compare their intended behavior with the current issue state and existing email handling; done means the newline behavior is consistent and covered by appropriate tests.

Written by the indexing model from the issue text.

Description

stdlib topic-email type-bug
BPO 975330
Nosy @warsaw, @devdanzin, @bitdancer
Files
  • Charset.diff: Patch to change email.Charset as described
  • crlf-body-encode.patch
  • base_encode_tests.patch: Base encode patch tests
  • crlf_base64_body_encode.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2004-06-18.12:50:50.000>
    labels = ['type-bug', 'expert-email']
    title = 'Inconsistent newline handling in email module'
    updated_at = <Date 2012-05-28.18:40:32.448>
    user = 'https://bugs.python.org/iko'
    

    bugs.python.org fields:

    activity = <Date 2012-05-28.18:40:32.448>
    actor = 'r.david.murray'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['email']
    creation = <Date 2004-06-18.12:50:50.000>
    creator = 'iko'
    dependencies = []
    files = ['1309', '21541', '22473', '25748']
    hgrepos = []
    issue_num = 975330
    keywords = []
    message_count = 5.0
    messages = ['21213', '82058', '133028', '139098', '161798']
    nosy_count = 5.0
    nosy_names = ['barry', 'iko', 'ajaksu2', 'r.david.murray', 'davbo']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'needs patch'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue975330'
    versions = ['Python 3.3']
    

    Dominant language
    Python
    Stars
    77.2k
    Forks
    36k
    Avg merge
    1d 9h
    Merged PRs (30d)
    558

    Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    More from python/cpython

    All issues in python/cpython

    Similar issues

    More Python issues

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.