python / python/cpython

`LOAD_FAST_BORROW; POP_TOP` pairs should be removed

Open
#152,600 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

interpreter-core performance topic-parser type-feature
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

Feature or enhancement

Proposal:

I noticed that


def f(x):
    x

produces these instructions:

  3           RESUME                   0

  4           LOAD_FAST_BORROW         0 (x)
              POP_TOP
              LOAD_COMMON_CONSTANT     7 (None)
              RETURN_VALUE
Full reproducer

from dis import dis

def f(x):
    x

dis(f)

The compiler should get rid of any LOAD_FAST_BORROW; POP_TOP pairs.

I will work on this.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
  • gh-152643

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the CPython compiler path that emits the LOAD_FAST_BORROW and POP_TOP instructions for the provided function reproducer. Use dis(f) to verify that the pair is gone while the function still returns None; the issue also links PR gh-152643, so check that work before starting.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.