python / python/cpython

Replace ctypes based Windows console calls in `_pyrepl`

Open
#150,582 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

OS-windows stdlib topic-repl type-refactor
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

My preference is still that we ought to be actively migrating from ctypes to a proper native module for these. Performance and reliability will thank us.

Originally posted by @zooba in #132888

  • GetStdHandle (already exist in _winapi)
  • WaitForSingleObject (already exist in _winapi)
  • GetConsoleMode
  • SetConsoleMode
  • GetConsoleScreenBufferInfo
  • ScrollConsoleScreenBufferW
  • ReadConsoleInputW
  • FlushConsoleInputBuffer
Linked PRs
  • gh-150584

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the _pyrepl console-call paths and compare the existing _winapi implementations for GetStdHandle and WaitForSingleObject with the remaining checklist. Review linked PR #150584 for current work; done means the listed Windows console calls no longer rely on ctypes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, operating-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.