Make the `PY_UNWIND` monitoring event local
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 35.9k
- PR merge metrics
- PR metrics pending
Description
Feature or enhancement
Proposal:
I would like to propose making the PY_UNWIND monitoring event available as a local event. The rationale for doing this is that some tools can be interested in trapping per-function exit events. Currently, this is only possible with the PY_RETURN event when a function returns with a value. However, if a function is exited with an exception, there is no way of capturing that event on just that function. Making the PY_UNWIND event would allow monitoring tools to catch all function exit events.
import random, sys
m, e = sys.monitoring, sys.monitoring.events
m.use_tool_id(0, "debugger")
def monitor(event):
def _(f):
m.register_callback(0, event, f)
return _
@monitor(e.PY_START)
def _(*_, **__):
print("entering", sys._getframe(1))
@monitor(e.PY_UNWIND)
def _(*_, **__):
print("exiting ", sys._getframe(1), "with exception")
def foo():
raise RuntimeError()
def bar():
return foo()
def baz():
return bar()
m.set_local_events(0, random.choice([foo, bar, baz]).__code__, e.PY_UNWIND | e.PY_START)
try:
baz()
except Exception:
pass
# entering <frame at 0x101602f80, file 'test_py_unwind_local.py', line 34, code baz>
# exiting <frame at 0x101602f80, file 'test_py_unwind_local.py', line 35, code baz> with exception
A debugger is an example of a tool that can benefit from PY_UNWIND being a local event.
The proposed change will break the current assumption that local events always require bytecode instrumentation. Instead, the PY_UNWIND event will simply make a local tool check instead of a global one inside monitor_unwind. No changes to bytecode or any other parts are required.
This is an extension of the current implementation of PEP 669 whereby PY_UNWIND will be available as a local event. The behaviour of the already existing global event will not be touched. As such, the proposed change will be guaranteed to be backwards-compatible.
Has this already been discussed elsewhere?
I have already discussed this feature proposal on Discourse
Links to previous discussion of this feature:
https://discuss.python.org/t/pep-669-low-impact-monitoring-for-cpython/13018/82
Linked PRs
- gh-142179
- gh-146182
- gh-148955
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the monitor_unwind entry point mentioned in the proposal and review linked PRs gh-142179, gh-146182, and gh-148955. Verify how a local PY_UNWIND registration is checked while preserving the existing global event behavior; done means monitoring tools can receive local function-exit events for unwinding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100