python / python/cpython

test_urllib2 alters the execution environment (unsetting `no_proxy`)

Open
#127,591 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tests type-bug
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

Bug report

Bug description:

Running the Python-3.13.1 test suite with make test, and:

1 test altered the execution environment (env changed):
    test_urllib2

The offending code pattern in several test cases is:

os.environ['no_proxy'] = '*'
# ... ...
del os.environ['no_proxy']

Thus if no_proxy already exists in the environment variable, these tests will remove it.

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs
  • gh-132584
  • gh-132585

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the CPython test suite with make test and inspect test_urllib2, focusing on the cases that set and delete no_proxy. The change is complete when the tests leave an existing no_proxy environment value intact and the suite reports no altered execution environment; linked PRs gh-132584 and gh-132585 indicate work is already underway.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.