[ssl] Reading from non-blocking socket wrapped by SSLContext returns an empty bytes object in case if the client stays connected
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 35.9k
- PR merge metrics
- PR metrics pending
Description
Bug report
Bug description:
I run my client-server application using SSLContext. And during communication I faced with situation when I receive an empty bytes object from the socket on server side. But in Wireshark dump I can see that client is present and sends data. If I add some delay after I receive empty bytes and try read from socket again I get some data. My code properly works on python 3.8 but it fails on 3.12. Also I tested without ssl on 3.12 and it works fine.
# how the socket initiated:
context = ssl.SSLContext(ssl.PROTOCOL_TLS_SERVER)
context.load_cert_chain(*ssl_context)
self.socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
self.socket.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
self.socket.bind((host, port))
self.socket.listen(1)
self.socket = context.wrap_socket(self.socket, server_side=True)
# how I accept client:
while not True:
self.socket.settimeout(1)
try:
self.connection, _ = self.socket.accept()
self.connection.settimeout(0.01)
break
except (socket.timeout, ssl.SSLError):
continue
# how I read the data:
def read_data(self):
data = b''
if self.connection is not None:
try:
print(f"start recv at: {datetime.now().isoformat()}")
if data := self.connection.recv(256):
print(f"finish recv at: {datetime.now().isoformat()}")
return data
else:
print(f"no data at: {datetime.now().isoformat()}")
self.connection = None
return b''
except (socket.timeout, OSError):
return data
return data
CPython versions tested on:
3.12
Operating systems tested on:
Linux
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The payload names no repository files or tests. Start by reproducing the supplied SSLContext and socket sequence on Linux with Python 3.8 and 3.12, then trace the SSL-wrapped socket read path. Done means a connected client’s pending data is not reported as an empty read in the affected scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100