python / python/cpython

Add an `proto_addr_info` argument to sock_connect in asyncio

Open
#123,174 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type-feature
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

Feature or enhancement

Proposal:

Allow the selection of the protocol used by getaddrinfo by adding an additional, optional parameter proto_addr_info which defaults to None.

If not specified, use the protocol used by the socket ( = previous behaviour).

This change is needed to allow custom protocols to be used with the sock_connect, because these protocols may raise an error when calling getaddrinfo (result in a ai_proto not supported error). An example of such protocol is MPTCP (https://mptcp.dev)

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
  • gh-123175

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the asyncio sock_connect entry point and trace its getaddrinfo call to understand how the socket protocol is currently selected. Review linked PR gh-123175 and the existing asyncio networking tests; done means the optional proto_addr_info behavior is covered without changing the default behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.