python / python/cpython

Fixes missing dependencies in Makefile

Open
#119,538 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build dependencies type-bug
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

Bug report

Bug description:

This Makefile fixes an issue in the cpython. Specifically, previously, any modifications of files like Modules/expat/*.c would not trigger a rebuild of Modules/expat/xmltok.o
Makefile_fixed.zip
. The Makefile fixes this by including them as additional dependencies.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
  • gh-119647
  • gh-119685
  • gh-119686
  • gh-125389
  • gh-125998

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the CPython Makefile and the dependency rules for Modules/expat/xmltok.o. Compare them with the attached Makefile_fixed.zip and verify that modifying files under Modules/expat/*.c triggers a rebuild of xmltok.o. The linked PRs indicate that this work has already moved elsewhere.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.